OCM-22668 | feat: Implement no-cni for HCP clusters

[paulczar]

What this PR does / why we need it:

reviving PR-903

Makes it possible to configure a HCP cluster without a CNI, like with rosa cluster create --no-cni

Implementing it like the rosa CLI does it: https://github.com/openshift/rosa/blob/4f425f6d857bb7b1ddb7af8fc69a25d25ce8fae3/pkg/ocm/clusters.go#L939

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):
Fixes #885
JIRA https://issues.redhat.com/browse/OCM-22668

[openshift-ci]

Hi @paulczar. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gdbranco]

/ok-to-test

[paulczar]

the prow test failure seems to be unrelated and have to do with the vpc not being deleted because of left over ENIs. which I believe is a known problem at this point.

[olucasfreitas]

/retest-required

[olucasfreitas]

/retest-required

[olucasfreitas]

@paulczar lgtm to me, before I approve, please rebase the branch and squash the commits into one, you can use the name of this PR so it follows our standard. Also, this is more for next time, please fill out the PR template that is going to show up, It will help us a lot here :)

after those changes are made I'll approve this

[olucasfreitas]

/retest-required

[paulczar]

thanks mate, I did a rebase and squash, hopefully I didn't mess it up too bad :)

[olucasfreitas]

@paulczar the commit message should be OCM-22668 | feat: Implement no-cni for HCP clusters, after you edit it, also rebase this with our main, I made some changes that should help fix the test issues we are having, I already approved this, so just let the tests run and it should merge automatically, I'll keep an eye for any hiccups.

[olucasfreitas]

/test all
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [olucasfreitas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olucasfreitas]

/retest-required

[olucasfreitas]

/retest-required