Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some preliminary work on an improved logging system inspired by Robot Raconteur. It is designed to carry more information about the log event for displaying to the user in an "event viewer" format, or for clients to automatically interpret the log information to make decisions.
The
TesseractLogRecordhas this initial format:This improvement also introduces the concept of
LogManagerandLogRecordHandler. Ideally all classes in tesseract will carry an instance variable tostd::weak_ptr<LogManager>, or possibly a uint32 ID to the log manager currently being used. For the Robot Raconteur service there may be more than one active client so it is necessary to send the log to the correct manager so it is received by the relevant client.See also https://github.com/robotraconteur/robotraconteur/blob/master/RobotRaconteurCore/include/RobotRaconteur/Logging.h , https://github.com/robotraconteur/robotraconteur/blob/master/RobotRaconteurCore/src/Logging.cpp , and https://github.com/robotraconteur/robotraconteur_standard_robdef/blob/master/group1/com.robotraconteur.eventlog.robdef
This work is still incomplete and is being submitted for discussion.