Refactor tests

[nulllpc]

Description

• Properly setup react-native mock
• Migrate tests to a separate dir similar to other WDK modules
• Adding missing tests for new logic
• Clean up and remove old mocks/tests
• Update dependencies for tests

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1213791008009710

[nulllpc]

The coverage is around 80%, I think it's high enough to cover most operations, going for higher coverage will demand quite a bit of effort

[claudiovb]

Good work on the test migration and new coverage.

Left some inline comments on specific files. A few additional notes:

Pre-existing (not introduced by this PR, but worth fixing since we're refactoring tests):

accountService.test.ts: The 'should throw error if HRPC not available' test (line 329) passes but for the wrong reason: the mock state is missing isWorkletStartedPromise and isWorkletInitializedPromise, so it hits a TypeError before reaching the hrpc check.
Fix:

mockWorkletStore.getState = jest.fn(() => ({
  isInitialized: true,
  hrpc: null,
  isWorkletStartedPromise: { promise: Promise.resolve() },
  isWorkletInitializedPromise: { promise: Promise.resolve() },
  wdkConfigs: {},
}))

await expect(
  AccountService.callAccountMethod('ethereum', 0, 'getBalance')
).rejects.toThrow('WDK not initialized or wdkConfigs not available')

The try/catch in storeHelpers.ts masks it.

Same file: duplicate should throw error if result is null' test block (lines 351-369).

[claudiovb]

This ensureWorkletStarted() call appears redundant: WalletSetupService.createNewWallet already calls ensureWorkletStarted() as its first action, and checkWallet only touches secure storage so it doesn't need the worklet.

The subtle side effect is that the loading state transition is now delayed until the worklet is confirmed started, whereas before the UI would see loading immediately. This seems like a tiny UX downgrade, unless you have some other reason for adding this line?

Note that if you agree and we revert this, the "Worklet Lifecycle Integration" test (line 614 of the test file) asserts ensureWorkletStarted is called at the hook level, which would only pass with this new line, so that test would need to change also.

If you want to verify that createNewWallet gates on ensureWorkletStarted before calling initializeWDK, that test belongs in walletSetupService.test.ts where the real service code runs, I was thinking something like:

it('should ensure worklet is started before initializing WDK', async () => {
  const callOrder: string[] = [];
  (WorkletLifecycleService.ensureWorkletStarted as jest.Mock).mockImplementation(() => {
    callOrder.push('ensureWorkletStarted');
    return Promise.resolve();
  });
  (WorkletLifecycleService.initializeWDK as jest.Mock).mockImplementation(() => {
    callOrder.push('initializeWDK');
    return Promise.resolve();
  });
  await WalletSetupService.createNewWallet();
  expect(callOrder).toEqual(['ensureWorkletStarted', 'initializeWDK']);
});

Not blocking since double-awaiting is a no-op, but wanted to flag it.

[claudiovb]

The try/catch wrapping here makes sense for giving consumers a clean error message. One small suggestion: consider also passing the original error as cause so error monitoring tools can still access the root failure:

Suggested change

	throw new Error('WDK not initialized')
	throw new Error('WDK not initialized', { cause: e })

The logWarn covers developer visibility in console, but cause ensures consumer apps with error monitoring or programmatic error handling can still access the root failure.

[claudiovb]

The include in tsconfig.json enumerates specific test files, but many are missing (e.g., all of tests/utils/, tests/services/, tests/hooks/useAddressLoader.test.tsx, etc.). This means tsc, noEmit won't type-check most tests.

Switching to "tests//*" surfaces just one type error (in useAppLifecycle.test.tsx:90). Could we either fix the remaining type issues and simplify to "tests//*", or if there's any other reason I'm missing?

tsconfig.json:

Suggested change

	"include": ["src/**/*", "tests/store", "tests/*", "tests/provider/WdkAppProvider.test.tsx", "tests/hooks/useWorklet.test.tsx", "tests/hooks/useWdkApp.test.tsx", "tests/hooks/useWalletManager.test.tsx", "tests/hooks/useBalance.test.tsx"],
	"include": ["src/**/*", "tests/**/*"],

Then you'll need to adapt useAppLifecycle.test.tsx:
javascript const removeFn = (AppState.addEventListener as jest.Mock).mock.results[0]?.value?.remove;

[claudiovb]

The new jest.config.cjs file uses react preset this could be removed

[claudiovb]

Same as above here, remove

[claudiovb]

Suggested change

	mockUseMultiAddressLoader.mockReturnValue({ addresses: {}, isLoading: false, error: addressErr });
	mockUseMultiAddressLoader.mockReturnValue({ addresses: [], isLoading: false, error: addressErr });

[claudiovb]

Suggested change

	mockUseMultiAddressLoader.mockReturnValue({ addresses: { 'ethereum-0': 'mock-eth-addr', 'polygon-0': 'mock-poly-addr' }, isLoading: false, error: null });
	mockUseMultiAddressLoader.mockReturnValue({ addresses: [{ network: 'ethereum', address: 'mock-eth-addr' }, { network: 'polygon', address: 'mock-poly-addr' }], isLoading: false, error: null });

[claudiovb]

Super minor but this comment got me really confused when reading the test as it says "unchanged" but the state did change from not_loaded to ready, which seems the point of this test (invalid transitions are allowed in production). Maybe update the comment to clarify that.

[claudiovb]

The @src path alias (line 20) isn't used anywhere in tests or source. Can be removed to keep config clean.

[claudiovb]

createWalletStore() is a singleton but beforeEach only clears mocks, not store state. Tests that mutate state could leak into subsequent tests. Adding a state reset would prevent that:

Suggested change

	jest.clearAllMocks()
	jest.clearAllMocks()
	createWalletStore().setState(mockInitState, true)

Longer term, a resetWalletStore() export similar to workletStore's resetWorkletStore() would be cleaner.