feat(base-cluster/backup): make k8up a bit more configurable

[marvinWolff]

Summary by CodeRabbit

• Chores
  • k8up backup behavior is now configurable via values: the skip-without-annotation setting can be enabled or disabled (defaults to false).
  • Configuration schema updated to add and validate a boolean skipWithoutAnnotation setting for k8up, ensuring deployments can declare and be validated for this option.

[coderabbitai]

Walkthrough

Replaced a hard-coded k8up backup provider flag with a Helm-templated value and added the corresponding boolean entry to the chart's values schema so the flag can be set via Helm values (defaults to false when not provided).

Changes

Cohort / File(s)	Summary
K8up template charts/base-cluster/templates/backup/k8up/k8up.yaml	Replaced hardcoded skipWithoutAnnotation: true with `skipWithoutAnnotation: {{ .Values.backup.provider.k8up.skipWithoutAnnotation
Values schema charts/base-cluster/values.schema.json	Added boolean property skipWithoutAnnotation under global.k8up (declared in global.properties.k8up.properties) and preserved additionalProperties: false.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat(base-cluster/backup)!: add k8up provider #1751: Previously added the k8up provider and set skipWithoutAnnotation: true; touches the same template/value.

Suggested reviewers

• tasches
• teutonet-bot

Poem

🐰 Hopping through YAML, I twitch my nose,

Values now bend where the cool breeze blows,
No more hard truths nailed fast in place,
Helm sings softly — flexible grace.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "feat(base-cluster/backup): make k8up a bit more configurable" directly relates to the main change in the changeset, which involves making the k8up backup configuration more flexible by allowing the skipWithoutAnnotation parameter to be controlled via Helm values instead of being hard-coded. The title is clear, concise, and specific enough that a teammate scanning the repository history would immediately understand the primary change. The conventional commit format and scoping (base-cluster/backup) add helpful context without introducing noise or vagueness.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/base-cluster/k8up_configuration

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3868c13 and 84a83c0.

📒 Files selected for processing (2)

• charts/base-cluster/templates/backup/k8up/k8up.yaml (1 hunks)
• charts/base-cluster/values.schema.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• charts/base-cluster/values.schema.json
• charts/base-cluster/templates/backup/k8up/k8up.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: check licenses
• GitHub Check: lint helm chart (base-cluster)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a4c774 and 4552eaf.

📒 Files selected for processing (2)

• charts/base-cluster/templates/backup/k8up/k8up.yaml (1 hunks)
• charts/base-cluster/values.schema.json (1 hunks)

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4552eaf and 3868c13.

📒 Files selected for processing (2)

• charts/base-cluster/templates/backup/k8up/k8up.yaml (1 hunks)
• charts/base-cluster/values.schema.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• charts/base-cluster/templates/backup/k8up/k8up.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: check licenses
• GitHub Check: Update release-please config file for a possibly new chart
• GitHub Check: lint helm chart (base-cluster)

[cwrau]

Suggested change

	"skipWithoutAnnotation": {
	"includeWithoutAnnotation": {

[cwrau]

Suggested change

	skipWithoutAnnotation: {{ .Values.backup.provider.k8up.skipWithoutAnnotation | default false }}
	skipWithoutAnnotation: {{ .Values.backup.provider.k8up.includeWithoutAnnotation | default false | not }}