fix/lint-scripts - #6
Conversation
fix: add lint:ci and lint:fix scripts
📝 WalkthroughWalkthroughThree new npm scripts were added to package.json: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
12-13: LGTM! Consider enhancinglint:cifor stricter CI enforcement.The
lint:fixscript is a solid addition for local development. Thelint:ciscript provides semantic clarity, though it currently mirrors the baselintcommand.💡 Optional: Make CI linting stricter
You might want to make
lint:cifail on warnings in CI environments:- "lint:ci": "next lint", + "lint:ci": "next lint --max-warnings 0",This ensures that warnings don't accumulate in the codebase over time.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json
🔇 Additional comments (1)
package.json (1)
22-22: LGTM! Verify fail-fast behavior is intentional.The
test:allscript correctly chains unit and E2E tests. The&&operator means E2E tests will only run if unit tests pass, which is typically the desired behavior for comprehensive test runs.If you prefer to run both test suites regardless of individual failures (for complete CI reporting), you could use
&(parallel) or;(sequential without fail-fast) instead of&&.
fix: add lint:ci and lint:fix scripts
Summary by CodeRabbit
lint:ciandlint:fixfor linting operations, andtest:allfor running complete test suite with end-to-end tests.✏️ Tip: You can customize this high-level summary in your review settings.