CE-333 php 8.2 compat #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the Community Submission page generates the following notice for two lines:
DeprecatedCalling get_class() without arguments is deprecatedwp-content/plugins/the-events-calendar-community-events/vendor/the-events-calendar/wp-router/WP_Router_Sample.class.phpget_class()without arguments is deprecated in PHP 8.0+, andget_class($this)won't work here because we're in a static method context.The solution is to use
__CLASS__instead ofget_class(). The__CLASS__magic constant returns the name of the current class and works perfectly in static contexts.Screenshot before the fix with the deprecation message.
Screenshot after the fix without the deprecation message.
There is a slightly different PR here using
get_called_class().get_called_class() vs CLASS
get_called_class():__CLASS__: