Skip to content

fix: do not overwrite files while Cflag_count reaches Wflag #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: do not overwrite files while Cflag_count reaches Wflag #1333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d2576d
fix: do not overwrite files while Cflag_count reaches Wflag
ManzeonYip Jun 26, 2025
623abd9
Merge branch 'the-tcpdump-group:master' into master
ManzeonYip Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tcpdump.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3328,8 +3328,11 @@ dump_packet_and_trunc(u_char *user, const struct pcap_pkthdr *h, const u_char *s

Cflag_count++;
if (Wflag > 0) {
if (Cflag_count >= Wflag)
if (Cflag_count >= Wflag) {
Cflag_count = 0;
pcap_breakloop(dump_info->pd);
goto end;
}
}
if (dump_info->CurrentFileName != NULL)
free(dump_info->CurrentFileName);
Expand All @@ -3349,6 +3352,7 @@ dump_packet_and_trunc(u_char *user, const struct pcap_pkthdr *h, const u_char *s
if (dump_info->ndo != NULL)
pretty_print_packet(dump_info->ndo, h, sp, packets_captured);

end:
--infodelay;
if (infoprint)
info(0);
Expand Down