Switch FOREMAN_PLUGINS to the short names#26
Draft
ekohl wants to merge 1 commit intotheforeman:masterfrom
Draft
Conversation
This relies on the foreman-plugin-$PLUGIN Provides statement that the packages should all have.
ekohl
commented
Apr 13, 2026
| echo $PLUGIN; \ | ||
| dnf install --nodocs -y "rubygem($PLUGIN)"; \ | ||
| dnf install --nodocs -y "foreman-plugin-$PLUGIN"; \ | ||
| echo "gem '$PLUGIN' if ENV.fetch('FOREMAN_ENABLED_PLUGINS', '').split.include?('$PLUGIN') || ENV.fetch('FOREMAN_ENABLED_PLUGINS', nil).nil?" > /usr/share/foreman/bundler.d/$PLUGIN.rb; \ |
Member
Author
There was a problem hiding this comment.
I just realized this won't work because it relied on the full gem name. We'd need to include this bit in the plugin template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relies on the
foreman-plugin-$PLUGINProvides statement that the packages should all have.