Conversation
evgeni
reviewed
Apr 17, 2026
evgeni
approved these changes
Apr 22, 2026
Member
evgeni
left a comment
evgeni
left a comment
There was a problem hiding this comment.
The remaining error is
FAILED tests/foreman_test.py::test_katello_services_status[candlepin_events] - KeyError: 'candlepin_events'
and is caused by the fact that candlepin_events is gone in nightly, but still present in foremanctl test suite.
As @amolpati30 fixed that recently in robottelo, I've asked him to look at the foremanctl tests too and make them not to have a hard-coded list of services to check.
You could add a -k 'not candlepin_events' to the pytest args here for now, but I don't think it's necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giving this idea a shot to be able to test image changes through PRs against a subset of
foremanctltests.