Feature/table support #49
Open
+367
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR! I’ll review and test it shortly, then follow up with feedback. |
Owner
|
I love the implementation — but yeah, as you mentioned, we have those issues. I’ll try to address the genpdfi problem in this PR, where I’m already adding font subsetting support. It would be great to include that fix in the new version of genpdfi. If you have any ideas about solving the raw-text-only issue, that would be super helpful. |
Contributor
Author
|
I added parsing context handling in #51, this would allow to parse only allowed tokens in the table cells. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #24
This PR adds support for markdown tables including alignment handling, from parsing to PDF rendering.
Styling config is minimal though.
However I found some issues while testing:
Content inside cells is only parsed into raw text because filtering incompatible token types (headings, images...) might require either reworking other functions or adding potential code duplication.
When genpdfi encounters an unbreakable string (long words, urls..) in table cells, it fails with "Page overflowed while trying to wrap a string".