Fix missing config values in webhook testing #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing for PHP 5.6 and 7.0 because phpunit no longer supports them as they've both reached end-of-life. |
|
Why did you add void return types? They are not supported in older PHP versions. |
|
I mistakenly ran the tests to confirm the change using my globally-installed version of phpunit rather than the one that ships with the project. The tests were failing because of the missing return types since phpunit no longer supports PHP versions 5.6 and 7.0. I removed the return types and re-ran the tests using the provided version of phpunit. |
Line item support
…ort-php-8 update dependencies to support php 8.1
feat(composer.json): update braintree/braintree_php dependency to version 6.0
…to fix compatibility issue with other dependencies
…p-v6x [OTT-1229] braintree_php sdk is past supported date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37