fix: use cross-env and shx for Windows-compatible npm scripts#28
Merged
Conversation
Contributor
|
Hi @Akihiro2004 , thanks! for raising the fix. |
Contributor
Author
Sure. |
This repo uses pnpm — package-lock.json should not be committed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Aditya-thesys
approved these changes
May 13, 2026
Contributor
Aditya-thesys
left a comment
There was a problem hiding this comment.
nit: could you use latest cross env package version
Contributor
|
thanks! for the contribution |
|
Hey @Akihiro2004 thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm scripts in both packages used Unix-only shell syntax that breaks on Windows. Running pnpm dev or building/packing the plugin on Windows would fail immediately.
Changes:
Test Plan