Replace fake-smtp-server with smtp4dev #128
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenny Pflug <[email protected]>
This command allows you to sign up for price drop notifications with an email address, product ID, and target price. The overall workflow should be: - list all products and pick the ID of the target product - call sign up to register your email address for a specific product and target price - drop the price Signed-off-by: Kenny Pflug <[email protected]>
…rvice and PriceWatcherService Signed-off-by: Kenny Pflug <[email protected]>
This migration inserts the same products that the in-memory repositories use to the Azure SQL database. Another great thing would be to actually retrieve the products in the price watcher service when checking that a product ID is valid. I also restructured the migrations in this commit: Script as well as PostMigration are now executed within the same transaction. Signed-off-by: Kenny Pflug <[email protected]>
Otherwise, we would need to adjust the whole Dockerfile infrastructure. Signed-off-by: Kenny Pflug <[email protected]>
The Dapr SMTP binding requires the target STMP server to use a TLS connection which fake-smtp-server does not support out-of-the-box. I replaced it with smtp4dev, a .NET-based solution which automatically creates self-signed certificates if necessary. See https://github.com/rnwood/smtp4dev Signed-off-by: Kenny Pflug <[email protected]>
|
The Helm charts for fake-smtp still need to be updated. |
|
Alternatively, we could also just leave fake-smtp-server in our Azure environment, I just realized that we use an nginx ingress server which handles TLS connections for fake-smtp-server. |
|
I tested the main branch locally. Works like a charm here: 
Having also a UI in front of the SMTP was mandatory for demonstration purpose, that's why we did not went the |
|
Do you use an older image of fake-smtp-server? I can't even access localhost:5080 on the main branch. That's because in this commit the default ports were changed (see also first commit in this PR).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the fake-smtp-server did not work at all in local dev mode with docker compose. The Dapr SMTP Binding always requires a TLS connection and fake-smtp-server cannot be configured to run with a self-signed certificate.
I thus replaced it with [smtp4dev], a .NET-based SMTP server which generates a self-signed certificate automatically if needed.
I also added a sign-up command to the AdminCLI in this PR. This way, we can perform the following commands with it:
Furthermore, the price watcher service and the products service now use the same products. I created a migration that inserts products with the appropriate ID. A single transaction now spans a migration.