fix: remove Unpin requirement

[thomaseizinger]

This removes the Unpin requirement introduced in #10 and #11 in favor of returning an Iterator of pinned references instead.

[thomaseizinger]

@elenaf9 @teor2345 What do you think of this? Is my unsafe code sound?

[teor2345]

I believe it is sound, but the safety requirements are stricter than the current comments. (In all 4 places.)

[teor2345]

Also, this will require a revert/change to the release notes I added in #11

[teor2345]

@thomaseizinger just checking if we can merge this at some point?

[thomaseizinger]

@thomaseizinger just checking if we can merge this at some point?

Yeah! Has this code been tested to work as expected for rust-libp2p?

[teor2345]

@thomaseizinger just checking if we can merge this at some point?

Yeah! Has this code been tested to work as expected for rust-libp2p?

I haven't had a chance, and I don't know if @elenaf9 has either.

[thomaseizinger]

Thanks for the review @teor2345, that removed two unsafes! 🎉

I'll go ahead and merge this, the tests are passing here and we have removed the Unpin requirement so I think this is good to go.

[thomaseizinger]

Would appreciate some testing in rust-libp2p before we cut the release.

[teor2345]

Would appreciate some testing in rust-libp2p before we cut the release.

Totally understandable, I'll see if I can get work time to do it.

[elenaf9]

Sorry, I didn't have the chance to test this yet either. Will try to find some time this weekend, but if not I'd appreciate your help @teor2345.