add test case for bind_graph on lists + implement fix #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented,
bind_graphindicates it supports passing a list of objects as .data.However, the current implementation does not support that use case; see #187
This code introduces a test (which the current main code fails) + a fix to provide the documented behavior of bind_graph (which is definitely worth having, and the extant code suggests is actually contemplated).
Alternatives considered: an unfocus.list method. That seems potentially reasonable, and perhaps useful for other areas of the code I didn't examine, but would also require some careful checking of method dispatch. I went with this approach as more surgical.