-
-
Notifications
You must be signed in to change notification settings - Fork 173
feat: add k8s secret retriever #3986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3986 +/- ##
==========================================
- Coverage 83.92% 83.81% -0.11%
==========================================
Files 137 138 +1
Lines 6813 6854 +41
==========================================
+ Hits 5718 5745 +27
- Misses 884 898 +14
Partials 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey thanks for opening this pull request. Do you have any use case where you thing this is better to have secrets instead of confimaps? |
Description
Retrieving feature flags from Kubernetes ConfigMap is already supported. Support for Kubernetes Secrets is missing.
This PR adds a
k8sretriever.SecretRetriever
implementation of theRetriever
interface. Also adds corresponding unit test.Checklist
README.md
and/website/docs
)