Skip to content

Small coding style fixes #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n-rodriguez wants to merge 1 commit into from
Closed

Small coding style fixes #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/appraisal/appraisal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ def bundle_options(options)
if Utils.support_parallel_installation?
options_strings << "--jobs=#{jobs}"
else
warn "Your current version of Bundler does not support parallel installation. Please " +
"upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option."
warn "Your current version of Bundler does not support parallel installation. Please " \
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [98/80]

"upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option."
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [100/80]

end
end

Expand Down
6 changes: 3 additions & 3 deletions lib/appraisal/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ def strip_heredoc(string)
method_option "retry", type: :numeric, default: 1,
desc: "Retry network and git requests that have failed"
method_option "without", banner: "GROUP_NAMES",
desc: "A space-separated list of groups referencing gems to skip " +
"during installation. Bundler will remember this option."
desc: "A space-separated list of groups referencing gems to skip " \
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

"during installation. Bundler will remember this option."
method_option "full-index", type: :boolean,
desc: "Run bundle install with the " \
"full-index argument."
"full-index argument."
method_option "path", type: :string,
desc: "Install gems in the specified directory. " \
"Bundler will remember this option."
Expand Down
4 changes: 2 additions & 2 deletions lib/appraisal/git.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def to_s
if @options.empty?
"git #{Utils.prefix_path(@source).inspect} do\n#{indent(super)}\nend"
else
"git #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" +
"git #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" \
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [92/80]

"#{indent(super)}\nend"
end
end
Expand All @@ -25,7 +25,7 @@ def for_dup
if @options.empty?
"git #{@source.inspect} do\n#{indent(super)}\nend"
else
"git #{@source.inspect}, #{Utils.format_string(@options)} do\n" +
"git #{@source.inspect}, #{Utils.format_string(@options)} do\n" \
"#{indent(super)}\nend"
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/appraisal/path.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def to_s
if @options.empty?
"path #{Utils.prefix_path(@source).inspect} do\n#{indent(super)}\nend"
else
"path #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" +
"path #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" \
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [93/80]

"#{indent(super)}\nend"
end
end
Expand All @@ -25,7 +25,7 @@ def for_dup
if @options.empty?
"path #{@source.inspect} do\n#{indent(super)}\nend"
else
"path #{@source.inspect}, #{Utils.format_string(@options)} do\n" +
"path #{@source.inspect}, #{Utils.format_string(@options)} do\n" \
"#{indent(super)}\nend"
end
end
Expand Down
16 changes: 8 additions & 8 deletions lib/appraisal/task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@ def initialize
namespace :appraisal do
desc "DEPRECATED: Generate a Gemfile for each appraisal"
task :gemfiles do
warn "`rake appraisal:gemfile` task is deprecated and will be removed soon. " +
"Please use `appraisal generate`."
warn "`rake appraisal:gemfile` task is deprecated and will be removed soon. " \
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [89/80]

"Please use `appraisal generate`."
exec "bundle exec appraisal generate"
end

desc "DEPRECATED: Resolve and install dependencies for each appraisal"
task :install do
warn "`rake appraisal:install` task is deprecated and will be removed soon. " +
"Please use `appraisal install`."
warn "`rake appraisal:install` task is deprecated and will be removed soon. " \
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [89/80]

"Please use `appraisal install`."
exec "bundle exec appraisal install"
end

desc "DEPRECATED: Remove all generated gemfiles from gemfiles/ folder"
task :cleanup do
warn "`rake appraisal:cleanup` task is deprecated and will be removed soon. " +
"Please use `appraisal clean`."
warn "`rake appraisal:cleanup` task is deprecated and will be removed soon. " \
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [89/80]

"Please use `appraisal clean`."
exec "bundle exec appraisal clean"
end

Expand All @@ -35,8 +35,8 @@ def initialize
desc "DEPRECATED: Run the given task for appraisal #{appraisal.name}"
task appraisal.name do
ARGV.shift
warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " +
"Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [103/80]

"Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
Copy link
Copy Markdown

@hound hound Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [85/80]

exec "bundle exec appraisal #{appraisal.name} rake #{ARGV.join(' ')}"
end
end
Expand Down
Loading