Add support for before build callback #1760
Merged
+110
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the approach for calling the before_build_callback, now it is called before the object is built, and thus called without any attributes
neilvcarvalho
commented
Aug 1, 2025
| end | ||
|
|
||
| def result(evaluation) | ||
| evaluation.notify(:before_build, nil) |
There was a problem hiding this comment.
Added only to the strategies that also trigger after_build, skipping build_stubbed (debatable) and attributes_for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(originally from @mohammednasser-32 - I couldn't push modifications to your branch, so I'm creating a new one with your original commits and my new ones)
Fixes #1633
Supersedes #1639
add support for
before(:build)callback as requested in the issueTested the changes by adding the local gem to a project
