refactor: StrategySyntaxMethodRegistrar doesn't need to be a class #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+4
to
8
| def self.define_strategy_methods(strategy_name) | ||
| define_singular_strategy_method(strategy_name) | ||
| define_list_strategy_method(strategy_name) | ||
| define_pair_strategy_method(strategy_name) | ||
| end |
There was a problem hiding this comment.
Hum, I think I prefer the object oriented approach given how how strategy_name is passed around. I'd consider defining the define_strategy_methods class method as new(strategy_name).define_strategy_methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE — this is dependent on the
refactor-internal-modulebranch #1772The
StrategySyntaxMethodRegistrardoesn't need to be instantiated (and doesn't need to be a class) to perform the behavior it implements. This refactors it into a more functional module.