feat(server): add RX option for inline object response in SET and FSET #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the RX option to SET and FSET commands, enabling clients to request immediate, inline object responses in various formats after mutations. Enhances usability by allowing flexible response types such as object, point, bounds, hash, and support for WITHFIELDS. Updates tests to cover new RX behaviors.
Owner
|
Sorry for the slow response. Regarding the 'RX' option name. I wondering if naming it to 'GET' would be clearer in general. |
Contributor
Author
|
Could we then take it a small step further and name it |
Owner
|
Sure. I'm good with RETURN. |
Replaces the "RX" argument with "RETURN" in SET and FSET commands for improved clarity and readability. Updates all relevant logic and test cases to match the new option, ensuring consistency across the codebase.
Contributor
Author
|
Refactored to be "RETURN" |
Owner
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the RX option to SET and FSET commands, enabling clients to request immediate, inline object responses in various formats after mutations. Enhances usability by allowing flexible response types such as object, point, bounds, hash, and support for WITHFIELDS. Updates tests to cover new RX behaviors.
Please do not open a pull request without first filing an issue and/or discussing the feature directly with the project maintainer.
Please ensure you adhere to every item in this list
Issue number and link
#790