Skip to content

Add a feature to build jemalloc with cc crate#163

Draft
Zoxc wants to merge 1 commit intotikv:mainfrom
Zoxc:cc_build
Draft

Add a feature to build jemalloc with cc crate#163
Zoxc wants to merge 1 commit intotikv:mainfrom
Zoxc:cc_build

Conversation

@Zoxc
Copy link
Copy Markdown

@Zoxc Zoxc commented Apr 21, 2026

This adds a feature to build jemalloc with cc crate instead of using autotools. This allows building on Windows without a Unix environment.

This was written by an LLM for the purposes of testing jemalloc with rustc on Windows. I am posting this in case there's interest in supporting Windows.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bba37692-1f95-43a1-8a77-e582596c0f28

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 21, 2026

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • ced83c9 Add a feature to build jemalloc with cc crate
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 21, 2026

Welcome @Zoxc! It looks like this is your first PR to tikv/jemallocator 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant