Replace org_must_have_owner trigger with app-level check#58
Merged
Conversation
The BEFORE DELETE/UPDATE trigger on org_member fired during the cascade from `delete from org`, blocking deletion of any org you owned. The trigger was designed for member-management (preventing the last owner from being removed) but couldn't distinguish that from a cascading org delete. Now removeMember and updateRole enforce the invariant in the application layer, where the cascade path skips the check entirely. The check uses `select ... for update` on the remaining owner rows to close the race the trigger already had: two concurrent owner removals could each see the other as still present and proceed, leaving the org with zero owners. With the row locks, the second transaction blocks on the first and observes the post-commit count. Migration 008 drops the trigger and helper function. Adds a regression test verifying `deleteOrg` cascades cleanly when the deleting user is the sole owner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BEFORE DELETE/UPDATE trigger on org_member fired during the cascade from
delete from org, blocking deletion of any org you owned. The trigger was designed for member-management (preventing the last owner from being removed) but couldn't distinguish that from a cascading org delete.Now removeMember and updateRole enforce the invariant in the application layer, where the cascade path skips the check entirely. The check uses
select ... for updateon the remaining owner rows to close the race the trigger already had: two concurrent owner removals could each see the other as still present and proceed, leaving the org with zero owners. With the row locks, the second transaction blocks on the first and observes the post-commit count.Migration 008 drops the trigger and helper function. Adds a regression test verifying
deleteOrgcascades cleanly when the deleting user is the sole owner.