Drop deleted engines from worker rotation instead of failing the batch#59
Merged
Drop deleted engines from worker rotation instead of failing the batch#59
Conversation
When an engine was deleted between discover() refreshes, processBatch threw "schema does not exist" which bubbled to the worker's generic error handler — reporting a top-level exception, starving sibling engines later in the rotation, and forcing exponential backoff for up to ~60s until the next refresh removed the dead schema. Now the per-target loop catches SQLSTATE 3F000 (invalid_schema_name), logs a warning, drops the target from the in-memory list, and continues to the next engine. Same handling on pruneQueue covers the claim/prune race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an engine was deleted between discover() refreshes, processBatch threw "schema does not exist" which bubbled to the worker's generic error handler — reporting a top-level exception, starving sibling engines later in the rotation, and forcing exponential backoff for up to ~60s until the next refresh removed the dead schema.
Now the per-target loop catches SQLSTATE 3F000 (invalid_schema_name), logs a warning, drops the target from the in-memory list, and continues to the next engine. Same handling on pruneQueue covers the claim/prune race.