feat(convert): support nested JSONB paths for dotted Sigma field names#45
Merged
feat(convert): support nested JSONB paths for dotted Sigma field names#45
Conversation
When json_field is set, dotted Sigma field names like securityContext.isProxy now generate chained -> / ->> operators (data->'securityContext'->>'isProxy') instead of a flat key lookup (data->>'securityContext.isProxy'). This matches the eval crate's nested traversal behavior and produces correct SQL for nested JSON documents like Okta System Log events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json_fieldis set, dotted Sigma field names (e.g.securityContext.isProxy) now generate chained->/->>PostgreSQL JSONB operators (data->'securityContext'->>'isProxy') instead of a flat top-level key lookup (data->>'securityContext.isProxy').rsigma-eval'sJsonEvent::get_field, which splits dotted field names on.and walks into nested JSON objects.data->>'eventType'.Test plan
test_jsonb_nested_field_access: two-level nested path with string equalitytest_jsonb_deeply_nested_field: four-level nested path (a.b.c.d)test_jsonb_nested_field_exists:|existsmodifier on a nested pathtest_jsonb_nested_field_cidr:|cidrmodifier on a nested pathtest_jsonb_nested_field_regex:|remodifier on a nested pathtest_jsonb_flat_field_unchanged: regression guard for flat fieldscargo clippy --workspace --all-targets --all-features -- -D warningscleancargo fmt --all -- --checkclean