Fix further CI issues - #10496
Conversation
|
@svenklemm, @akuzm: please review this pull request.
|
0ff5ec2 to
8f9d1c7
Compare
| version=$(wget -q --tries=6 --waitretry=15 https://api.github.com/repos/timescale/timescaledb/releases/latest -O - | jq -r .tag_name) | ||
| echo "version=${version}" | ||
| echo "version=${version}" >>$GITHUB_OUTPUT | ||
| version=$(wget -q --tries=9 --waitretry=20 --retry-connrefused --retry-on-http-error=503 https://api.github.com/repos/timescale/timescaledb/releases/latest -O - | jq -r .tag_name) |
There was a problem hiding this comment.
It's hitting rate limits. Maybe we should replace it with gh api call that runs outside of container with the standard actions github token, in some previous step?
There was a problem hiding this comment.
I will try a more graceful retry strategy first
There was a problem hiding this comment.
- name: Get version of latest release
id: versions
env:
GH_TOKEN: ${{ github.token }}
run: |
version=$(gh api repos/${{ github.repository }}/releases/latest --jq .tag_name)
echo "version=${version}" >>$GITHUB_OUTPUT
The thing I have in mind is something like this. Maybe it can run inside container too, not sure. It looks kind of weird that we're working around unauthenticated API access from inside a github action. You can pass the token to wget too if you wish, it goes somewhere into the http header.
There was a problem hiding this comment.
I'm happy to try this. I'm still concerned that the rate limiting was not the only cause of the frequent github issues we have seen. There were too many problems with github infra in the past year.
There was a problem hiding this comment.
The image doesn't have the gh tool and it needs other fragile things, like getting the keyring, adding another repo and then insalling from it. I will stick to wget and add the auth token.
There was a problem hiding this comment.
we could fall back to previous_version in version.config
8f9d1c7 to
e933500
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
8ce612e to
450cbce
Compare
2664b5b to
ffc43a4
Compare
Occasionally, we can't get the latest version from GitHub, causing intermittent CI errors. The culprit is this URL: `api.github.com/repos/timescale/timescaledb/releases/latest`. I added better reporting in the CI workflows so it is more obvious when this happens, and I also added more retries and error handling to 'wget'. The 'keyserver.ubuntu.com' also started failing requests, so I added a fallback to 'keys.openpgp.org' for the code-style/clang-tidy tests. Disable-check: force-changelog-file
ffc43a4 to
625a881
Compare
5 participants
Occasionally, we can't get the latest version from GitHub, causing intermittent CI errors. The culprit is this URL:
api.github.com/repos/timescale/timescaledb/releases/latest. I added better reporting in the CI workflows so it is more obvious when this happens, and I also added more retries and error handling to 'wget'.The 'keyserver.ubuntu.com' also started failing requests, so I added a fallback to 'keys.openpgp.org' for the code-style/clang-tidy tests.
Disable-check: force-changelog-file