Skip to content

Remove CAgg time bucket function metadata table#8172

Draft
kpan2034 wants to merge 5 commits intotimescale:mainfrom
kpan2034:cagg_drop_bucket_func
Draft

Remove CAgg time bucket function metadata table#8172
kpan2034 wants to merge 5 commits intotimescale:mainfrom
kpan2034:cagg_drop_bucket_func

Conversation

@kpan2034
Copy link
Member

@kpan2034 kpan2034 commented May 22, 2025

Closes #7349

@kpan2034 kpan2034 requested a review from fabriziomello May 22, 2025 21:40
@philkra philkra added this to the v2.21.0 milestone May 23, 2025
@philkra philkra mentioned this pull request May 23, 2025
@fabriziomello fabriziomello changed the title Remove time bucket function metadata table Remove CAgg time bucket function metadata table May 27, 2025
@fabriziomello fabriziomello added Continuous Aggregate tech-debt Needs refactoring and improvement tasks related to the source code and its architecture. labels May 27, 2025
@kpan2034 kpan2034 force-pushed the cagg_drop_bucket_func branch 2 times, most recently from 006d039 to ff495c4 Compare May 30, 2025 21:58
@kpan2034 kpan2034 force-pushed the cagg_drop_bucket_func branch 2 times, most recently from b250ba9 to 6a01e29 Compare June 10, 2025 22:43
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.69%. Comparing base (a465f3f) to head (5435476).
⚠️ Report is 456 commits behind head on main.

Files with missing lines Patch % Lines
src/ts_catalog/continuous_agg.c 63.63% 1 Missing and 3 partials ⚠️
src/cross_module_fn.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8172      +/-   ##
==========================================
- Coverage   82.23%   80.69%   -1.55%     
==========================================
  Files         256      256              
  Lines       48170    47567     -603     
  Branches    12152    11919     -233     
==========================================
- Hits        39614    38384    -1230     
- Misses       3699     4417     +718     
+ Partials     4857     4766      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kpan2034 kpan2034 force-pushed the cagg_drop_bucket_func branch from 6a01e29 to 5435476 Compare June 11, 2025 13:40
@fabriziomello fabriziomello removed this from the v2.21.0 milestone Jun 23, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days.

@github-actions github-actions bot added the Stale label Oct 23, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days.

@kpan2034 kpan2034 force-pushed the cagg_drop_bucket_func branch from 5435476 to bf3a6a9 Compare December 3, 2025 00:31
@kpan2034 kpan2034 force-pushed the cagg_drop_bucket_func branch from bf3a6a9 to 3279038 Compare December 3, 2025 00:42
extern TSDLLEXPORT DebugRequireOption ts_guc_debug_require_batch_sorted_merge;

extern TSDLLEXPORT bool ts_guc_debug_allow_cagg_with_deprecated_funcs;
extern TSDLLEXPORT char *ts_guc_hypercore_indexam_whitelist;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extern TSDLLEXPORT char *ts_guc_hypercore_indexam_whitelist;

looks like a rebase error

@github-actions
Copy link

This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Continuous Aggregate no-activity Stale tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Remove useless metadata table _timescaledb_catalog.continuous_aggs_bucket_function

4 participants