Conversation
The key is a preceding insert and refresh that results in a row in the materialization log of [-infinity, CAGG_INVALIDATION_WRONG_GREATEST_VALUE]. Then a following incremental refresh with start-offset = NULL would cause the issue before the fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8547 +/- ##
==========================================
+ Coverage 82.38% 82.46% +0.08%
==========================================
Files 248 248
Lines 47606 47577 -29
Branches 12092 12088 -4
==========================================
+ Hits 39220 39236 +16
- Misses 3497 3506 +9
+ Partials 4889 4835 -54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days. |
|
We are closing this pull request due to lack of activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key for the reproducer is a preceding insert and refresh that results in a row in the materialization log of
[-infinity, CAGG_INVALIDATION_WRONG_GREATEST_VALUE]. Then a following incremental refresh with start-offset = NULL would cause the issue before the fix (#8476).
Note that the fix didn't remove the row of [-infinity, CAGG_INVALIDATION_WRONG_GREATEST_VALUE], which looks like a bug caused by the use of -infinity and min_ts, making the range splitting logic think that there is still a range of [-infinity, min_ts -1] outside of the current refresh window of (min_ts, some_ts_value).
Variable window does not have this row in its materialization invalidation log because we use -infinity as the start_range for the refresh window.
Disable-check: force-changelog-file