Skip to content

Mark Columnar Scan as CUSTOMPATH_SUPPORT_PROJECTION#9211

Open
akuzm wants to merge 8 commits intotimescale:mainfrom
akuzm:projection-columnar
Open

Mark Columnar Scan as CUSTOMPATH_SUPPORT_PROJECTION#9211
akuzm wants to merge 8 commits intotimescale:mainfrom
akuzm:projection-columnar

Conversation

@akuzm
Copy link
Member

@akuzm akuzm commented Jan 30, 2026

It's already performing projections if needed, so there should be no changes to the execution side. This allows us to avoid unneeded Result nodes and makes the planning logic consistent with the execution logic.

Disable-check: force-changelog-file

It's already performing projections if needed, so there should be no
changes to the execution side. This allows us to avoid unneeded Result
nodes and makes the planning logic consistent with the execution logic.
@svenklemm
Copy link
Member

this was source of many problems in the past, are you sure we wanna do this?

@akuzm
Copy link
Member Author

akuzm commented Jan 30, 2026

this was source of many problems in the past, are you sure we wanna do this?

Yeah, but what problems? I'm trying to wrap my head around this, and for now I don't understand why this shouldn't work. We're already handling projections on the execution side. The planning and execution was rewritten almost completely during the last couple of years, so maybe it just works now. The old problems should be covered by tests, so hopefully we'll notice if something is wrong.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@akuzm akuzm marked this pull request as ready for review January 30, 2026 15:51
@akuzm akuzm requested a review from a team January 30, 2026 15:51
@svenklemm
Copy link
Member

this was source of many problems in the past, are you sure we wanna do this?

Yeah, but what problems? I'm trying to wrap my head around this, and for now I don't understand why this shouldn't work. We're already handling projections on the execution side. The planning and execution was rewritten almost completely during the last couple of years, so maybe it just works now. The old problems should be covered by tests, so hopefully we'll notice if something is wrong.

I think this was mostly expression not found in targetlist stuff, but my memory is very hazy since its a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants