Mark Columnar Scan as CUSTOMPATH_SUPPORT_PROJECTION#9211
Mark Columnar Scan as CUSTOMPATH_SUPPORT_PROJECTION#9211akuzm wants to merge 8 commits intotimescale:mainfrom
Conversation
It's already performing projections if needed, so there should be no changes to the execution side. This allows us to avoid unneeded Result nodes and makes the planning logic consistent with the execution logic.
|
this was source of many problems in the past, are you sure we wanna do this? |
Yeah, but what problems? I'm trying to wrap my head around this, and for now I don't understand why this shouldn't work. We're already handling projections on the execution side. The planning and execution was rewritten almost completely during the last couple of years, so maybe it just works now. The old problems should be covered by tests, so hopefully we'll notice if something is wrong. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
I think this was mostly expression not found in targetlist stuff, but my memory is very hazy since its a long time |
It's already performing projections if needed, so there should be no changes to the execution side. This allows us to avoid unneeded Result nodes and makes the planning logic consistent with the execution logic.
Disable-check: force-changelog-file