Skip to content

Remove continuous_agg_migrate_plan tables#9212

Open
svenklemm wants to merge 1 commit intomainfrom
sven/drop_cagg_migrate_tables
Open

Remove continuous_agg_migrate_plan tables#9212
svenklemm wants to merge 1 commit intomainfrom
sven/drop_cagg_migrate_tables

Conversation

@svenklemm
Copy link
Member

@svenklemm svenklemm commented Jan 30, 2026

These are left over from when the procedure to convert continuous
aggregate from partial format to new format were removed.

Disable-check: force-changelog-file

@svenklemm svenklemm requested a review from a team January 30, 2026 16:44
@github-actions
Copy link

@antekresic, @kpan2034: please review this pull request.

Powered by pull-review

@svenklemm svenklemm added this to the v2.26.0 milestone Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.78%. Comparing base (3a8a16e) to head (321dd35).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9212      +/-   ##
==========================================
+ Coverage   85.65%   85.78%   +0.12%     
==========================================
  Files         245      245              
  Lines       47966    47935      -31     
  Branches    10709    10708       -1     
==========================================
+ Hits        41085    41119      +34     
- Misses       3524     3526       +2     
+ Partials     3357     3290      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@natalya-aksman
Copy link
Member

Have to check that it won't break OSM: @gayyappan

@svenklemm svenklemm force-pushed the sven/drop_cagg_migrate_tables branch from 4d92ad7 to 52f6dfa Compare January 30, 2026 17:25
@gayyappan
Copy link
Member

Have to check that it won't break OSM: @gayyappan

Thanks for the callout. This is not a problem for OSM.

@svenklemm svenklemm force-pushed the sven/drop_cagg_migrate_tables branch 2 times, most recently from 3b91f6d to 4a1853f Compare January 30, 2026 19:20
@svenklemm svenklemm requested review from akuzm and pnthao January 30, 2026 19:24
@svenklemm svenklemm force-pushed the sven/drop_cagg_migrate_tables branch from 4a1853f to df41eec Compare January 30, 2026 19:27
These are left over from when the procedure to convert continuous
aggregate from partial format to new format were removed.
@svenklemm svenklemm force-pushed the sven/drop_cagg_migrate_tables branch from df41eec to 321dd35 Compare January 30, 2026 19:32
Copy link
Member

@fabriziomello fabriziomello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't removed this table to keep an execution history of the migration for customer. I think it should be removed in some releases in the future.

@svenklemm
Copy link
Member Author

I didn't removed this table to keep an execution history of the migration for customer. I think it should be removed in some releases in the future.

What is the useful content in this table that we need to keep it beyond 2.26?

@fabriziomello
Copy link
Member

I didn't removed this table to keep an execution history of the migration for customer. I think it should be removed in some releases in the future.

What is the useful content in this table that we need to keep it beyond 2.26?

CAgg migration execution history.

@svenklemm
Copy link
Member Author

I didn't removed this table to keep an execution history of the migration for customer. I think it should be removed in some releases in the future.

What is the useful content in this table that we need to keep it beyond 2.26?

CAgg migration execution history.

This is just the log and no longer relevant so i dont understand why we would need to keep it any longer cause any migrations happened months before the table gets removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants