Skip to content

don't run Broken dependencies test on 1.8 #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2022
Merged

don't run Broken dependencies test on 1.8 #673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7719d3e
don't run `Broken dependencies` test on 1.8
aviatesk Feb 19, 2022
db9b112
Update test/runtests.jl
aviatesk Feb 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3258,6 +3258,8 @@ do_test("Switching free/dev") && @testset "Switching free/dev" begin
push!(to_remove, depot)
end

# in v1.8 and higher, a package can't be loaded at all when its precompilation failed
@static if Base.VERSION < v"1.8.0-DEV.1451"
do_test("Broken dependencies (issue #371)") && @testset "Broken dependencies (issue #371)" begin
testdir = newtestdir()
srcdir = joinpath(testdir, "DepPkg371", "src")
Expand Down Expand Up @@ -3292,6 +3294,7 @@ do_test("Broken dependencies (issue #371)") && @testset "Broken dependencies (is
rm_precompile("DepPkg371")
pop!(LOAD_PATH)
end
end # @static if VERSION ≤ v"1.7"

do_test("Non-jl include_dependency (issue #388)") && @testset "Non-jl include_dependency (issue #388)" begin
push!(LOAD_PATH, joinpath(@__DIR__, "pkgs"))
Expand Down