Skip to content

If the board doesn't report a firmata version, ask for it #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theycallmeswift wants to merge 1 commit into
base: master
Choose a base branch
from
Open

If the board doesn't report a firmata version, ask for it #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions pyfirmata/pyfirmata.py
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@

# Time to wait after initializing serial, used in Board.__init__
BOARD_SETUP_WAIT_TIME = 5
FIRMATA_VERSION_REPORT_TIMEOUT = 5

class PinAlreadyTakenError(Exception):
pass
Expand Down Expand Up @@ -85,8 +86,17 @@ def __init__(self, port, layout, baudrate=57600, name=None):
# Iterate over the first messages to get firmware data
while self.bytes_available():
self.iterate()
# TODO Test whether we got a firmware name and version, otherwise there
# probably isn't any Firmata installed

if not self.firmata_version:
self.sp.write(chr(REPORT_VERSION))
start_time = time.time()
while not self.firmata_version:
self.iterate()

current_time = time.time()
if current_time - start_time > FIRMATA_VERSION_REPORT_TIMEOUT:
self.firmata_version = None
break # Version wasn't reported, let the user figure out what to do

def __str__(self):
return "Board %s on %s" % (self.name, self.sp.port)
Expand Down Expand Up @@ -233,6 +243,7 @@ def iterate(self):
byte = self.sp.read()
if not byte:
return

data = ord(byte)
received_data = []
handler = None
Expand Down Expand Up @@ -500,4 +511,4 @@ def write(self, value):
msg = chr(ANALOG_MESSAGE + self.pin_number)
msg += chr(value % 128)
msg += chr(value >> 7)
self.board.sp.write(msg)
self.board.sp.write(msg)