feat!: add err parameter to connectHandler#444
Open
acouvreur wants to merge 3 commits intotinygo-org:devfrom
Open
feat!: add err parameter to connectHandler#444acouvreur wants to merge 3 commits intotinygo-org:devfrom
acouvreur wants to merge 3 commits intotinygo-org:devfrom
Conversation
Platforms shall implement a way of retrieving the error in case of connection failure or unexpected disconnection to give more details to the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms shall implement a way of retrieving the error in case of connection failure or unexpected disconnection to give more details to the user.
Closes #443
Note that 6a863d6 implements a fix for darwin to call the connectHandler in two functions that were missing.