Fix UnboundLocalError in get_ns_string() for ONIX 3.1#7
Merged
titusz merged 1 commit intotitusz:masterfrom Oct 14, 2025
remo7k:fix/onix-31-unboundlocalerror
Merged
Fix UnboundLocalError in get_ns_string() for ONIX 3.1#7titusz merged 1 commit intotitusz:masterfrom remo7k:fix/onix-31-unboundlocalerror
titusz merged 1 commit intotitusz:masterfrom
remo7k:fix/onix-31-unboundlocalerror
Conversation
- Add support for ONIX 3.1 in OnixMeta.get_ns_string() method with correct 3.1 namespace - Add error handling for unsupported ONIX versions - Create test data files for ONIX 3.1 (reference and short formats) - Add comprehensive test coverage for ONIX 3.1 support Fixes the UnboundLocalError that occurred when validating ONIX 3.1 files because the 'tpl' variable was not defined for version 3.1. ONIX 3.1 uses its own namespace: http://ns.editeur.org/onix/3.1/{reference,short} Fixes #6
Owner
|
Thank you for you contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the UnboundLocalError that occurred when validating ONIX 3.1 files because the 'tpl' variable was not defined for version 3.1. ONIX 3.1 uses its own namespace: http://ns.editeur.org/onix/3.1/{reference,short}
Fixes #6