-
Notifications
You must be signed in to change notification settings - Fork 2
Add additional CI checks #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…l done with lint check fixes
|
Going through these 1 by 1 (can be addressed in followup PR) |
andrewkmin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏👏👏
| _cloneInto(to) { | ||
| to || (to = Object.create(Object.getPrototypeOf(this), {})); | ||
| const { oHash, iHash, finished, destroyed, blockLen, outputLen } = this; | ||
| to = to; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a linting error about self assignment. It does look a little weird. I'll add them to the eslintignore file later!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and oble-hashes are essentially vendored; we can ignore them from lint for now
Add Prettier, ESLint, and Build Validation CI Checks
Adds CI checks for code quality and build validation:
Code Quality Checks
.eslintrc.json) and lint scripts forexport,import, andexport-and-signNOTE:
I didn't fix any of the linting errors. I believe this can get done in a separate ticket.
Build Validation
distfolders match committed versions after runningnpm run buildimportandexport-and-signdistwasn't rebuilt and committedAll checks run in parallel using matrix strategies for faster CI execution.