Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
this pr includes:
api-key-stampersdk-typeshttpthe main difference between
sdk-serverandturnkey_httpis that the Python client is built on top ofsdk-types, which provides cleaner, easier-to-read generated types that the client uses directly. On the other hand,sdk-serverrelies on the OpenAPI-generated types from mono, which are a lot harder to read and work with. So I'd say the Python http client feels closer to the core client than it does tosdk-serverIt also includes a
client.send_signed_requesthelper that makes sending stamped requests really easy as a bonusWhy use Pydantic in our generated types?
we use it to handle field name conflicts with Python keywords. For example, some Turnkey API requests include a
fromfield (likev1EthSendTransactionIntent), which is a reserved keyword in Pythonpydantic's
Fieldaliasing allows us to:from_in Python code (avoiding syntax errors)fromwhen making API requests to TurnkeyTests
I’ve added 10 tests covering: