syscalls: Fix NULL pointer crash when enumerating kernel modules#1862
Closed
lfreijo wants to merge 1 commit intotklengyel:mainfrom
Closed
syscalls: Fix NULL pointer crash when enumerating kernel modules#1862lfreijo wants to merge 1 commit intotklengyel:mainfrom
lfreijo wants to merge 1 commit intotklengyel:mainfrom
Conversation
Add NULL check for module_info->full_name before accessing its contents in enum_modules_cb(). Some kernel modules (e.g., certain drivers in PID 4) do not have a full_name populated, causing a SIGSEGV when syscalls is combined with other plugins. This was the root cause of the crash (exit 139) when running syscalls alongside procmon, filetracer, and other plugins. The crash occurred during module enumeration on Windows, before any syscall events could be captured. Tested with 6-plugin combo (syscalls + procmon + filetracer + fileextractor + memdump + tlsmon) - 73,570 events, clean exit. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this bug while testing Windows 10 x64 with multiple plugins (syscalls + procmon + filetracer + fileextractor + memdump + tlsmon)
Add NULL check for module_info->full_name before accessing its contents in enum_modules_cb(). Some kernel modules (e.g., certain drivers in PID 4) do not have a full_name populated, causing a SIGSEGV when syscalls is combined with other plugins.
This was the root cause of the crash (exit 139) when running syscalls alongside procmon, filetracer, and other plugins. The crash occurred during module enumeration on Windows, before any syscall events could be captured.