Require typed answer for confirm #426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
reviewed
Feb 28, 2025
| from tests.utils import feed_cli_with_input | ||
|
|
||
|
|
||
| def test_confirm_enter_default_yes(): |
Owner
There was a problem hiding this comment.
Any reason you removed these tests? The default behaviour should stay the same
Owner
|
I think this is a good addition, do you want to follow up on the comment I made on the removed tests? If you re-add them I think we are good to merge @Celina1801 |
spmvoss
reviewed
Sep 4, 2025
| style: Optional[Style] = None, | ||
| auto_enter: bool = True, | ||
| instruction: Optional[str] = None, | ||
| mandatory: bool = True, |
There was a problem hiding this comment.
I would strongly suggest defaulting mandatory to False to preserve the default behaviour and avoid breaking people's code.
That will also resolve the issue with deletion of test cases. When mandatory defaults to false all existing test cases can remain the same and you only have to add new ones for mandatory=True case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
Closes #312
The confirm prompt currently allows users to bypass input by pressing "Enter," which automatically selects the default value. This behavior is problematic for critical confirmations (e.g., deleting files), where explicit user input (e.g., "y" or "n") should be required to ensure intentionality.
How did you solve it?
I introduced a mandatory parameter to the confirm prompt. When mandatory=True, the prompt enforces explicit user input ("y" or "n") and rejects empty or invalid inputs. The implementation modifies the key bindings to re-prompt the user until a valid response is provided.
Unit tests were added to ensure that:
Empty inputs are rejected when mandatory=True.
Valid responses ("y," "n," "Y," "N") are accepted.
Invalid inputs re-prompt the user for confirmation.
Checklist