[WIP] Optimistic download

[tmspzz]

As per #181 , if a version file exists trust that everything else is there too.

[hlintBot]

	22 Warnings
⚠️	PR is classed as Work in Progress
⚠️	src/CommandParsers.hs#L112 - Found Use <$> pure Download <*> udcPayloadParser Why Not Download <$> udcPayloadParser
⚠️	src/Lib.hs#L256 - Found Reduce duplication let finalRepositoryMapEntries = if _noIgnore noIgnoreFlag then repositoryMapEntries else repositoryMapEntries `filterRomeFileEntriesByPlatforms` ignoreMapEntries let repositoryMap = toRepositoryMap finalRepositoryMapEntries let reverseRepositoryMap = toInvertedRepositoryMap finalRepositoryMapEntries let finalIgnoreNames = if _noIgnore noIgnoreFlag then [] else ignoreFrameworks Why Not Combine with src/Lib.hs:359:5
⚠️	src/Lib.hs#L275 - Found Reduce duplication let filteredCurrentMapEntries = currentMapEntries `filterRomeFileEntriesByPlatforms` ignoreMapEntries let currentFrameworks = concatMap (snd . romeFileEntryToTuple) filteredCurrentMapEntries let currentFrameworkVersions = map (flip FrameworkVersion currentVersion) currentFrameworks let currentInvertedMap = toInvertedRepositoryMap filteredCurrentMapEntries Why Not Combine with src/Lib.hs:400:15
⚠️	src/Lib.hs#L295 - Found Redundant bracket if _noSkipCurrent noSkipCurrentFlag then (currentFrameworkVersions `filterOutFrameworksAndVersionsIfNotIn` finalIgnoreNames) else [] Why Not if _noSkipCurrent noSkipCurrentFlag then currentFrameworkVersions `filterOutFrameworksAndVersionsIfNotIn` finalIgnoreNames else []
⚠️	src/Lib.hs#L973 - Found Reduce duplication dwarfUUIDs <- dwarfUUIDsFrom (frameworkDirectory </> fwn) maybeUUIDsArchives <- liftIO $ forM dwarfUUIDs $ \ dwarfUUID -> runMaybeT $ do dwarfArchive <- exceptToMaybeT $ createZipArchive (bcSymbolMapPath dwarfUUID) verbose return (dwarfUUID, dwarfArchive) unless skipLocalCache $ forM_ maybeUUIDsArchives $ mapM $ \ (dwarfUUID, dwarfArchive) -> maybe (return ()) liftIO $ runReaderT <$> (saveBcsymbolmapToLocalCache <$> mlCacheDir <*> Just dwarfUUID <*> Just dwarfArchive <*> Just reverseRomeMap <*> Just fVersion <*> Just platform) <*> Just (cachePrefix, s, verbose) Why Not Combine with src/Lib.hs:1189:7
⚠️	src/Lib.hs#L1008 - Found Reduce duplication frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f platformBuildDirectory = carthageArtifactsBuildDirectoryForPlatform platform f frameworkDirectory = platformBuildDirectory </> frameworkNameWithFrameworkExtension dSYMNameWithDSYMExtension = frameworkNameWithFrameworkExtension <> ".dSYM" dSYMdirectory = platformBuildDirectory </> dSYMNameWithDSYMExtension bcSymbolMapPath d = platformBuildDirectory </> bcsymbolmapNameFrom d Why Not Combine with src/Lib.hs:1088:3
⚠️	src/Lib.hs#L1008 - Found Reduce duplication frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f platformBuildDirectory = carthageArtifactsBuildDirectoryForPlatform platform f frameworkDirectory = platformBuildDirectory </> frameworkNameWithFrameworkExtension dSYMNameWithDSYMExtension = frameworkNameWithFrameworkExtension <> ".dSYM" dSYMdirectory = platformBuildDirectory </> dSYMNameWithDSYMExtension bcSymbolMapPath d = platformBuildDirectory </> bcsymbolmapNameFrom d Why Not Combine with src/Lib.hs:1224:3
⚠️	src/Lib.hs#L1282 - Found Reduce duplication saveBinaryToLocalCache lCacheDir versionFileBinary (prefix </> versionFileRemotePath) versionFileName verbose liftIO $ saveBinaryToFile versionFileBinary versionFileLocalPath sayFunc $ "Copied " <> versionFileName <> " to: " <> versionFileLocalPath Why Not Combine with src/Lib.hs:1801:17
⚠️	src/Lib.hs#L1297 - Found Reduce duplication versionFileName = versionFileNameForProjectName $ fst projectNameAndVersion versionFileLocalPath = carthageBuildDirectory </> versionFileName versionFileRemotePath = remoteVersionFilePath projectNameAndVersion Why Not Combine with src/Lib.hs:1816:3
⚠️	src/Lib.hs#L1398 - Found Reduce duplication saveBinaryToLocalCache lCacheDir frameworkBinary (prefix </> remoteFrameworkUploadPath) fwn verbose deleteFrameworkDirectory fVersion platform verbose unzipBinary frameworkBinary fwn frameworkZipName verbose <* ifExists frameworkExecutablePath (makeExecutable frameworkExecutablePath) Why Not Combine with src/Lib.hs:1616:17
⚠️	src/Lib.hs#L1430 - Found Reduce duplication let symbolmapLoggingName = fwn <> "." <> bcsymbolmapNameFrom dwarfUUID let bcsymbolmapZipName d = bcsymbolmapArchiveName d version let localBcsymbolmapPathFrom d = platformBuildDirectory </> bcsymbolmapNameFrom d Why Not Combine with src/Lib.hs:1647:21
⚠️	src/Lib.hs#L1440 - Found Reduce duplication saveBinaryToLocalCache lCacheDir symbolmapBinary (prefix </> remoteBcSymbolmapUploadPathFromDwarf dwarfUUID) fwn verbose deleteFile (localBcsymbolmapPathFrom dwarfUUID) verbose unzipBinary symbolmapBinary symbolmapLoggingName (bcsymbolmapZipName dwarfUUID) verbose Why Not Combine with src/Lib.hs:1657:21
⚠️	src/Lib.hs#L1475 - Found Reduce duplication saveBinaryToLocalCache lCacheDir dSYMBinary (prefix </> remotedSYMUploadPath) dSYMName verbose deleteDSYMDirectory fVersion platform verbose unzipBinary dSYMBinary dSYMName dSYMZipName verbose Why Not Combine with src/Lib.hs:1691:17
⚠️	src/Lib.hs#L1486 - Found Reduce duplication frameworkZipName = frameworkArchiveName f version remoteFrameworkUploadPath = remoteFrameworkPath platform reverseRomeMap f version remoteBcSymbolmapUploadPathFromDwarf dwarfUUID = remoteBcsymbolmapPath dwarfUUID platform reverseRomeMap f version dSYMZipName = dSYMArchiveName f version remotedSYMUploadPath = remoteDsymPath platform reverseRomeMap f version platformBuildDirectory = carthageArtifactsBuildDirectoryForPlatform platform f dSYMName = fwn <> ".dSYM" frameworkExecutablePath = frameworkBuildBundleForPlatform platform f </> fwn Why Not Combine with src/Lib.hs:1702:3
⚠️	src/Lib.hs#L1528 - Found Use lambda-case \ e -> case e of ErrorGettingDwarfUUIDs -> sayFunc $ "Error: Cannot retrieve symbolmaps ids for " <> fwn (FailedDwarfUUIDs dwardUUIDsAndErrors) -> mapM_ (sayFunc . snd) dwardUUIDsAndErrors Why Not \case ErrorGettingDwarfUUIDs -> sayFunc $ "Error: Cannot retrieve symbolmaps ids for " <> fwn (FailedDwarfUUIDs dwardUUIDsAndErrors) -> mapM_ (sayFunc . snd) dwardUUIDsAndErrors
⚠️	src/Types/Commands.hs#L28 - Found Use newtype instead of data data RomeUtilsPayload = RomeUtilsPayload{_subcommand :: RomeUtilsSubcommand} deriving (Show, Eq) Why Not newtype RomeUtilsPayload = RomeUtilsPayload{_subcommand :: RomeUtilsSubcommand} deriving (Show, Eq)
⚠️	src/Utils.hs#L378 - Found Use tuple-section \ f -> (f, g) Why Not (, g)
⚠️	tests/Tests.hs#L138 - Found Use uncurry \ (a, b) -> a || b Why Not uncurry (||)
⚠️	tests/Tests.hs#L155 - Found Redundant bracket (unProjectName (_projectName r)) ++ " = " ++ f Why Not unProjectName (_projectName r) ++ " = " ++ f
⚠️	tests/Tests.hs#L156 - Found Redundant bracket (map show) (_frameworks r) Why Not map show (_frameworks r)
⚠️	tests/Tests.hs#L183 - Found Move brackets to avoid $ (length $ base `filterRomeFileEntriesByPlatforms` filteringValues) <= length base Why Not length (base `filterRomeFileEntriesByPlatforms` filteringValues) <= length base

Generated by 🚫 Danger

[ollieatkinson]

@blender Thanks for this work, it will certainly save us a lot of time... would you be able to make a pre-release binary (or point me in the right direction) so I can test it and provide feedback?

[tmspzz]

Hi, I am not close to my computer at the moment. I will make a pre release on Monday. If you feel adventurous you can try to compile yourself. Instructions are in the read me.

…

Sent from my iPhone

On 31 May 2019, at 17:21, Oliver Atkinson ***@***.***> wrote: @blender Thanks for this work, it will certainly save us a lot of time... would you be able to make a pre-release binary with this so I can test it and provide feedback? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[ollieatkinson]

Thanks for the pointer @blender - I got the branch compiled, but it did not do what I expect. I assumed it would do the following:

1. Check the Cartfile.resolved against the .version file
2. If a match, no files relating to the framework would be requested (including bcsymbolmaps)
3. If there's a version mismatch, or lack of a version file then it would download all of the files relating to the framework.

I was not seeing the above behaviour, all files relating to the frameworks with valid version files were still being downloaded.

However, there's a good chance I did not set it up correctly as I'm new to Rome.

edit:

That could be useful but still .dYSM and .bcsymbolmap are not checksummed in the .version file so they would need to be downloaded again.

I have just seen your comment on the original issue, maybe this is what I am seeing - is it safe to add an option which does not download those files if the version file is present?

[tmspzz]

Did you run it with —optimistic ?

…

Sent from my iPhone

On 1 Jun 2019, at 14:04, Oliver Atkinson ***@***.***> wrote: Thanks for the pointer @blender - I got the branch compiled, but it did not do what I expect. I assumed it would do the following: Check the Cartfile.resolved against the .version file If a match, no files relating to the framework would be requested (including bcsymbolmaps) If there's a version mismatch, or lack of a version file then it would download all of the files relating to the framework. I was not seeing the above behaviour, all files relating to the frameworks with valid version files were still being downloaded. However, there's a good chance I did not set it up correctly as I'm new to Rome. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[ollieatkinson]

Did you run it with —optimistic ?

Yes

[tmspzz]

This needs tests if anyone looking for hacktoberfest issues wants to finish it

[hlintBot]

⚠️	Found Use <$> pure Upload <*> udcPayloadParser Why Not Upload <$> udcPayloadParser

[hlintBot]

⚠️

Found Use lambda-case \ e -> case e of ErrorGettingDwarfUUIDs -> sayFunc $ "Error: Cannot retrieve symbolmaps ids for " <> fwn (FailedDwarfUUIDs dwardUUIDsAndErrors) -> mapM_ (sayFunc . snd) dwardUUIDsAndErrors Why Not \case ErrorGettingDwarfUUIDs -> sayFunc $ "Error: Cannot retrieve symbolmaps ids for " <> fwn (FailedDwarfUUIDs dwardUUIDsAndErrors) -> mapM_ (sayFunc . snd) dwardUUIDsAndErrors

[vytautasgimbutas]

Any progress on this PR?

[tmspzz]

@vytautasgimbutas it needs to be adapted to the current code base and it needs integration tests. Do you want to give it a shot?

[felipe-azevedo]

I'd be very interested in this too.
Is there an ETA for it?

[felipe-azevedo]

When this is made available, can you also please include the "optimistic" parameter in the fasltane rome plugin?
Many thanks for this!

[ollieatkinson]

Contributions are accepted @felipe-azevedo