update in app webview with iphone os 17 #460
Open
osamamohammed98 wants to merge 3 commits intotneotia:masterfrom
Open
update in app webview with iphone os 17 #460osamamohammed98 wants to merge 3 commits intotneotia:masterfrom
osamamohammed98 wants to merge 3 commits intotneotia:masterfrom
Conversation
osamamohammed98
changed the title
enricostrijks
suggested changes
Oct 4, 2023
Author
|
Well, I will update the library with the latest version and upload again. Is that enough to accept the request? |
Author
|
done you can check it |
enricostrijks
approved these changes
Oct 4, 2023
enricostrijks
left a comment
enricostrijks
left a comment
There was a problem hiding this comment.
To me this looks great, @tneotia you should merge this to support ios 17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i have issue when i want to build ios app after search i see you use
in-app- webview lib and after update mac os
it have a problem so i use the solution in your lib and make pull request