Skip to content

Conversation

ignasi42
Copy link

No description provided.

@ignasi42 ignasi42 force-pushed the fix/reporting-improvements branch from 76047e7 to 8158264 Compare January 24, 2023 18:23
Copy link
Owner

@tnicola tnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!Can you please revert the first change? (Using a fixed column width)

head: ['Spec', 'Time', 'Tests', 'Passing', 'Failing', 'Pending'],
style: { head: ['blue'] },
colWidths: [50, 8, 7, 9, 9, 9]
colWidths: [100, 10, 10, 10, 10, 10]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!A fixed width could not work for everyone, and people using small screens would end up seeing a messed up table. I think I found a better solution by making the width flexible based on the spec name length:

colWidths: [getMaxPathLenghtFrom(testSuitePaths), 10, 10, 10, 10, 10]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants