Conversation
This adds an MSRV policy to tock-registers. This policy currently matches libtock-rs: bump to a newer stable release anytime doing so is convenient. This MSRV is specified in Cargo.toml and is tested against in CI.
brghena
approved these changes
Feb 4, 2026
Contributor
brghena
left a comment
There was a problem hiding this comment.
Looks good to me. Updating to a newer version of Rust can be spun into other updates to the system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an MSRV policy to tock-registers. This policy currently matches libtock-rs: bump to a newer stable release anytime doing so is convenient. This MSRV is specified in Cargo.toml and, when combined with #6, tests it in CI.
1.82 is the earlier stable Rust version that can run
cargo clippywithout warnings (earlier version give the error clippy::unused_result_ok). Note that 1.82 does not support the 2024 edition, if we want to update that then we should switch to 1.85.