Skip to content

fix(core): trash style - #15306

Merged
darkskygit merged 1 commit into
canaryfrom
darksky/fix-trash-style
Jul 21, 2026
Merged

fix(core): trash style#15306
darkskygit merged 1 commit into
canaryfrom
darksky/fix-trash-style

Conversation

@darkskygit

@darkskygit darkskygit commented Jul 21, 2026

Copy link
Copy Markdown
Member

fix #15259

PR Dependency Tree

This tree was auto-generated by Charcoal

Summary by CodeRabbit

  • Bug Fixes
    • Truncated long document titles to 64 characters in the “Move to trash” confirmation dialog, improving readability and preventing overly long modal titles.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c8172519-53e7-4dba-bc98-3c4548cb6bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 7318ef1 and adeed1f.

📒 Files selected for processing (1)
  • packages/frontend/core/src/mobile/pages/workspace/detail/page-header-more-button.tsx

📝 Walkthrough

Walkthrough

The mobile workspace header menu now truncates document titles to 64 characters when displaying the move-to-trash confirmation modal.

Changes

Trash modal title display

Layer / File(s) Summary
Apply title truncation
packages/frontend/core/src/mobile/pages/workspace/detail/page-header-more-button.tsx
Imports truncate from lodash-es and limits the confirmation modal title to 64 characters.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and related to the change: it updates the trash confirmation modal's display behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying blocksuite-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: adeed1f
Status: ✅  Deploy successful!
Preview URL: https://d89ce8d7.blocksuite-docs.pages.dev
Branch Preview URL: https://darksky-fix-trash-style.blocksuite-docs.pages.dev

View logs

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.80%. Comparing base (7318ef1) to head (adeed1f).
⚠️ Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #15306      +/-   ##
==========================================
- Coverage   60.72%   57.80%   -2.92%     
==========================================
  Files        3311     3309       -2     
  Lines      191936   191887      -49     
  Branches    28277    27485     -792     
==========================================
- Hits       116548   110923    -5625     
- Misses      71600    77141    +5541     
- Partials     3788     3823      +35     
Flag Coverage Δ
server-test 75.13% <ø> (-5.55%) ⬇️
unittest 35.83% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@darkskygit
darkskygit merged commit fd0e3bd into canary Jul 21, 2026
64 of 67 checks passed
@darkskygit
darkskygit deleted the darksky/fix-trash-style branch July 21, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Bug]: I want to move the document trash but cant find any button to move

1 participant