Skip to content

fix res:json() is nil caused by content-type detect method #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix res:json() is nil caused by content-type detect method #30

wants to merge 1 commit into from

Conversation

whatwewant
Copy link

fix #29

tokers
tokers reviewed Dec 23, 2019
View reviewed changes
lib/resty/requests/response.lua
if content_type ~= "application/json"
and content_type ~= "application/json; charset=utf-8"
then
if not includes(content_type, "application/json") then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use string.find is enough to satisfy this demand.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you are right. See the issue first #29 , i have left some messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: res:json() is nil
2 participants
@whatwewant @tokers