fix(axum-macros): use OptionalFromRequest for Option<T> fields in derive#3665
Open
4Mathleu wants to merge 1 commit intotokio-rs:mainfrom
Open
fix(axum-macros): use OptionalFromRequest for Option<T> fields in derive#36654Mathleu wants to merge 1 commit intotokio-rs:mainfrom
4Mathleu wants to merge 1 commit intotokio-rs:mainfrom
Conversation
Option<T> fields in #[derive(FromRequest)] and #[derive(FromRequestParts)] now use OptionalFromRequest / OptionalFromRequestParts instead of calling .ok() on the result. This lets each extractor decide when to return None vs an error, instead of silently converting all rejections to None. Fixes: tokio-rs#3623
Contributor
|
What's with all the backslashes in the PR description? |
Contributor
Author
Formatting got mangled when writing the description (also maybe translation shit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Option<T>fields with#[from_request(via(...))]were using.ok()to convert any rejection intoNone, silently swallowing errors like invalid JSON.Fixes #3623
Solution
Use
OptionalFromRequest/OptionalFromRequestPartstraits instead of.ok(), letting each extractor decide when to returnNonevs propagate an error.