Skip to content

relax the version of matchit#3678

Closed
ADD-SP wants to merge 1 commit intov0.8.xfrom
add_sp/relax-matchit-ver
Closed

relax the version of matchit#3678
ADD-SP wants to merge 1 commit intov0.8.xfrom
add_sp/relax-matchit-ver

Conversation

@ADD-SP
Copy link
Copy Markdown
Member

@ADD-SP ADD-SP commented Mar 5, 2026

Pinning the matchit version in the library crate is inconvenient for downstream. In case of bugfix or new feature for axum's deps, downstream has to bump the version in axum crate instead of their own binary crate.

This PR relaxes the version, so that the axum only requires matchit >= 0.8.4. This is not a breaking change as downstream can keep using the 0.8.4.

#3143 is an example shows how inconvenient to pinning the matchit.

@ADD-SP ADD-SP added the A-axum label Mar 5, 2026
@ADD-SP ADD-SP changed the base branch from main to v0.8.x March 5, 2026 05:07
@ADD-SP ADD-SP closed this Mar 5, 2026
@ADD-SP ADD-SP deleted the add_sp/relax-matchit-ver branch March 5, 2026 05:24
@mladedav
Copy link
Copy Markdown
Collaborator

mladedav commented Mar 5, 2026

This was a conscious decision because we are parsing the path in runtime. We need matchit to reject everything we expect it to reject, so we can't allow new matchit features without explicit support in our extractors.

@ADD-SP
Copy link
Copy Markdown
Member Author

ADD-SP commented Mar 5, 2026

This was a conscious decision because we are parsing the path in runtime. We need matchit to reject everything we expect it to reject, so we can't allow new matchit features without explicit support in our extractors.

Yeah, I realized this after opening this PR, so I closed it, and opened a new one(#3679).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants