Closed
Conversation
Collaborator
|
This was a conscious decision because we are parsing the path in runtime. We need matchit to reject everything we expect it to reject, so we can't allow new matchit features without explicit support in our extractors. |
Member
Author
Yeah, I realized this after opening this PR, so I closed it, and opened a new one(#3679). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinning the
matchitversion in the library crate is inconvenient for downstream. In case of bugfix or new feature for axum's deps, downstream has to bump the version in axum crate instead of their own binary crate.This PR relaxes the version, so that the axum only requires
matchit >= 0.8.4. This is not a breaking change as downstream can keep using the0.8.4.#3143 is an example shows how inconvenient to pinning the
matchit.