Conversation
Co-authored-by: David Pedersen <david.pdrsn@gmail.com> Co-authored-by: Yann Simon <yann.simon@commercetools.com>
Signed-off-by: Antonio Souza <arfs.antonio@gmail.com>
Co-authored-by: Yann Simon <yann.simon.fr@gmail.com>
|
IMO changelog addition should be part of the release commit, not happen in its own commit. |
Normally, we ask each PR to update the changelog. |
Do you mean I should squash the commits updating the versions + the commit updating the release notes? Or do you mean I should not have kept the "unreleased" part of the changelog for each cherry-pick, and not change the "unreleased" for the next version like I did in df87dc8? I tend to think that you are meaning the 2nd one. |
Prepare following releases:
Cherry-picked:
vpathandjsonmacros are feature-gated #3615IntoResponsefor tuples overriding error response codes #3603 - in release notesclippy::implicit_cloneinTypedPathmacro expansions #3663Closes:
IntoResponseimplementation for(StatusCode, R) where R: IntoResponseoverrides error status codes and might be a footgun #2287