Skip to content

V0.8.9#3699

Open
yanns wants to merge 22 commits intov0.8.xfrom
v0.8.9
Open

V0.8.9#3699
yanns wants to merge 22 commits intov0.8.xfrom
v0.8.9

Conversation

@yanns
Copy link
Copy Markdown
Collaborator

@yanns yanns commented Mar 24, 2026

@yanns yanns changed the base branch from main to v0.8.x March 24, 2026 17:54
@yanns yanns marked this pull request as ready for review March 25, 2026 10:19
@Darksonn
Copy link
Copy Markdown
Member

IMO changelog addition should be part of the release commit, not happen in its own commit.

@yanns
Copy link
Copy Markdown
Collaborator Author

yanns commented Mar 30, 2026

IMO changelog addition should be part of the release commit, not happen in its own commit.

Normally, we ask each PR to update the changelog.
After review, I've found out that some changes were missing, and decided to add them. Is it ok to keep them?

@yanns
Copy link
Copy Markdown
Collaborator Author

yanns commented Apr 1, 2026

IMO changelog addition should be part of the release commit, not happen in its own commit.

Do you mean I should squash the commits updating the versions + the commit updating the release notes?

Or do you mean I should not have kept the "unreleased" part of the changelog for each cherry-pick, and not change the "unreleased" for the next version like I did in df87dc8?

I tend to think that you are meaning the 2nd one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.