Open
Conversation
- Split prefix/suffix/prefix+suffix tests, as these are now not allowed in the single segment. - Ignore nest_service prefix+suffix tests, as these fail due to what seems to be matchit issue (ibraheemdev/matchit#92). To be noted, similar prefix/suffix routes work fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Explained in #3140 - primarily to be able to use very desired prefixed or suffixed captures in routes, such as
router.route("/{id}.png").Solution
The work had already been done by @mladedav, but as I understand there were issues regarding conflicting routes handling in
matchit, which seem to have been resolved in0.9.1. I've rebased David's commit, bumpedmatchitto the latest version, and updated tests and documentation, mostly in regard to that prefixed and suffixed captures may no longer be mixed.In the process, I've discovered a bug in
matchit:/a{b}c/and/a{b}croutes conflict while they shouldn't (and, notably, they do not conflict when added in different order). This fails some tests, which I've silenced and added similar tests using prefixed (as opposed to prefixed+suffixed) captures, so the related code (router nesting) is still covered.