Add rich error message for context message graph#1283
Open
kriswuollett wants to merge 2 commits intotokio-rs:masterfrom
Open
Add rich error message for context message graph#1283kriswuollett wants to merge 2 commits intotokio-rs:masterfrom
kriswuollett wants to merge 2 commits intotokio-rs:masterfrom
Conversation
caspermeijn
requested changes
May 26, 2025
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
This error message is better than before, but it still doesn't explain what is happening. As a user of prost I don't know what a message graph is.
I feel like get_message should never have been called for a message name that is not in the graph. I think there is another underlaying problem that needs to be fixed.
caspermeijn
approved these changes
Jul 14, 2025
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
This still doesn't help a user when it gets this error. But at least it is better than an unwrap on None
caspermeijn
requested changes
Jul 14, 2025
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
Sorry to bother you one more time. can_message_derive_eq has the same get_message. Could you add the same message to that as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1282