Don't crash when extern type used as field#1285
Open
kriswuollett wants to merge 1 commit intotokio-rs:masterfrom
Open
Don't crash when extern type used as field#1285kriswuollett wants to merge 1 commit intotokio-rs:masterfrom
kriswuollett wants to merge 1 commit intotokio-rs:masterfrom
Conversation
caspermeijn
requested changes
Jun 19, 2025
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
This is a good workaround. Please add a test to prevent a future regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for extern types lacking trait implementations metadata in #1284.