Chrono interoperability and Ops for Timestamp, update Nix and README #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other develop rust_minimum_version for tests
- Implement Add, Sub and Div math operations; - Create unitary testes for Ops; - Create kani tests for ops; - Update kani tests for chrono conversions; - Add unitary testes for chrono conversions.
- Add support for MSRV tokio with `nix develop .#rust_minimum_version`; - Update readme, with this nix command.
caspermeijn
requested changes
Sep 9, 2025
| /// `Timestamp`s are likely representable on 64-bit Unix-like platforms, but other platforms, | ||
| /// such as Windows and 32-bit Linux, may not be able to represent the full range of | ||
| /// `Timestamp`s. | ||
| #[cfg(feature = "std")] |
There was a problem hiding this comment.
This seems like a breaking change
| } | ||
|
|
||
| #[cfg(feature = "chrono")] | ||
| mod p_chrono { |
There was a problem hiding this comment.
Let's not abbreviate short words: proof_chrono
| mod p_chrono { | ||
| use super::*; | ||
| use ::chrono::{DateTime, NaiveDate, NaiveDateTime}; | ||
| //Why does it limit? In testing, it was left for more than 2 hours and not completed. |
There was a problem hiding this comment.
What does this comment mean?
| let seconds = kani::any(); | ||
| let nanos = kani::any(); | ||
|
|
||
| kani::assume(i64::MAX / 3 < seconds); |
There was a problem hiding this comment.
Why divide by 3? Please explain the the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, a huge thanks to all the contributors for this great library!
Changes:
Arithmetic Operations for Timestamp
Enhanced chrono Interoperability, with chrono feature
Nix Development Environment Update
nix develop .#rust_minimum_versionnow correctly sets up a development shell with the appropriate Minimum Supported Rust Version (MSRV) required by Tokio.A Note on the README
I have updated the README.md to include documentation for the new Nix command. However, I noticed that the
check-readmeCI job is configured to fail automatically on any modification to the README.This pull request introduces NO breaking changes.